Pass signal **kwargs to index.should_update#73
Open
micahscopes wants to merge 1 commit intodjango-haystack:developfrom
Open
Pass signal **kwargs to index.should_update#73micahscopes wants to merge 1 commit intodjango-haystack:developfrom
**kwargs to index.should_update#73micahscopes wants to merge 1 commit intodjango-haystack:developfrom
Conversation
In the django-haystack documentation, [it's said](https://django-haystack.readthedocs.io/en/master/searchindex_api.html?highlight=should_update#SearchIndex.should_update) that signal keyword arguments will be passed to `should_update`, and sure enough they are [here](https://github.com/django-haystack/django-haystack/blob/802b0f6f4b3b99314453261876a32bac2bbec94f/haystack/indexes.py#L318-L319) I'm implementing custom signals to be used with celery-haystack and would like to do some fancy checking in `should_update` to see if my django model objects should be reindexed. I've made this same change in our fork of celery-haystack, and thought I'd submit it upstream. Looks like this is very tangentially related to issue django-haystack#61
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the django-haystack documentation, it's said that signal keyword arguments will be passed to
should_update, and sure enough they are here.I'm implementing custom signals to be used with celery-haystack and would like to do some fancy checking in
should_updateto see if my django model objects should be reindexed. I've made this same change in our fork of celery-haystack, and thought I'd submit it upstream.(Looks like this is very tangentially related to issue #61.)